From 92bb6ebe77d0f56fe3961264ca1e07dbd6bd5546 Mon Sep 17 00:00:00 2001
From: Kieran Ryan <kierankilkenny@gmail.com>
Date: Sat, 13 Jul 2024 17:02:01 +0100
Subject: [PATCH] Drop support for end-of-life node version 16 (#224)

* Drop node v16

* Use 'npm ci' in pipeline

* Changelog drop Node v16
---
 .github/workflows/release-npm.yml     | 5 +++--
 .github/workflows/test-javascript.yml | 9 +++------
 CHANGELOG.md                          | 3 +++
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/release-npm.yml b/.github/workflows/release-npm.yml
index 1ea0d283..2693e8ba 100644
--- a/.github/workflows/release-npm.yml
+++ b/.github/workflows/release-npm.yml
@@ -17,10 +17,11 @@ jobs:
           version: 2.0.24
       - uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '18'
           cache: 'npm'
           cache-dependency-path: package-lock.json
-      - run: npm install-test
+      - run: npm ci
+      - run: npm run test
       - uses: cucumber/action-publish-npm@v1.1.1
         with:
           npm-token: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/test-javascript.yml b/.github/workflows/test-javascript.yml
index 3f2f15af..f3b2f383 100644
--- a/.github/workflows/test-javascript.yml
+++ b/.github/workflows/test-javascript.yml
@@ -20,10 +20,7 @@ jobs:
           - macos-latest
           - ubuntu-latest
           - windows-latest
-        # 14.x is broken with @typescript-eslint 6.0
-        # 16.12.0 has broken ESM support
-        # 17.x cannot install tree-sitter: https://github.com/tree-sitter/tree-sitter/issues/1503
-        node-version: ['16.11.x', '18.x']
+        node-version: ['18.x']
 
     steps:
       - name: set git core.autocrlf to 'input'
@@ -40,9 +37,9 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
           cache-dependency-path: package-lock.json
-      - run: npm install
+      - run: npm ci
         if: ${{ matrix.os != 'windows-latest' }}
-      - run: npm install --no-optional
+      - run: npm ci --no-optional
         if: ${{ matrix.os == 'windows-latest' }}
       - run: npm test
       - run: npm run eslint
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ea434ff9..295e9ca7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - (PHP) Scoped query to match annotations only (`@Given`) ([#214](https://github.com/cucumber/language-service/pull/214))
 - (Go) Find godog step definitions within `method_declaration` ([#215](https://github.com/cucumber/language-service/pull/215))
 
+### Removed
+- Dropped support for end-of-life Node version 16 ([#224](https://github.com/cucumber/language-service/pull/224))
+
 ## [1.6.0] - 2024-05-12
 ### Added
 - Diagnostics for marking steps as undefined in scenario outlines ([#210](https://github.com/cucumber/language-service/pull/210))