Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DataTable#map_column 'strict' argument to a keyword argument #1594

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Change DataTable#map_column 'strict' argument to a keyword argument #1594

merged 2 commits into from
Dec 8, 2021

Conversation

aurelien-reeves
Copy link
Contributor

Description

Fixes #1592

Type of change

Please delete options that are not relevant.

  • Breaking change (will cause existing functionality to not
    work as expected)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@aurelien-reeves aurelien-reeves added this to the 8.0.0 milestone Dec 8, 2021
@aurelien-reeves aurelien-reeves merged commit 8461102 into main Dec 8, 2021
@luke-hill luke-hill deleted the fix-1592 branch August 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-hill luke-hill luke-hill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Change map_column 'strict' argument to a keyword argument
2 participants
@aurelien-reeves @luke-hill