Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message "TestRunFinished" always report "success: false" whatever the result of the execution is #1604

Closed
aurelien-reeves opened this issue Jan 5, 2022 · 0 comments
Labels
🐛 bug Defect / Bug
Milestone

Comments

@aurelien-reeves
Copy link
Contributor

Describe the bug
The "TestRunFinished" message does not report "success: true" if the run was actually ok.
It is actually not implemented at all. See the message_builder formatter: it does not set the success for the TestRunFinished message: https://github.com/cucumber/cucumber-ruby/blob/main/lib/cucumber/formatter/message_builder.rb#L229

To Reproduce
Run cucumber --format message. Whatever your tests are failing or passing, {"testRunFinished":{"success":false is always reported.

Expected behavior
{"testRunFinished":{"success": depends on the execution and may be true if no failure is reported. It should match the result of the cucumber command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

1 participant