Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove former 'stdin' parameter from Cucumber::Cli::Main#initialize #1581

Closed
aurelien-reeves opened this issue Nov 5, 2021 · 0 comments · Fixed by #1588
Closed

Remove former 'stdin' parameter from Cucumber::Cli::Main#initialize #1581

aurelien-reeves opened this issue Nov 5, 2021 · 0 comments · Fixed by #1588
Labels
🏦 debt Tech debt
Milestone
8.0.0

Comments

@aurelien-reeves
Copy link
Contributor

https://github.com/cucumber/cucumber-ruby/blob/main/lib/cucumber/cli/main.rb#L17

Cucumber::Cli::Main#initialize has an unused parameter _ with a default nil value. It was a former stdin parameter. It is unused for years now.

Removing it would change the API, so it has to be removed as part of a new major version.
@aurelien-reeves aurelien-reeves added the 🏦 debt Tech debt label Nov 5, 2021
@aurelien-reeves aurelien-reeves added this to the 8.0.0 milestone Nov 5, 2021
@aurelien-reeves aurelien-reeves changed the title Deprecate then remove former 'stdin' parameter from Cucumber::Cli::Main#initialize Remove former 'stdin' parameter from Cucumber::Cli::Main#initialize Nov 5, 2021
This was referenced Nov 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏦 debt Tech debt
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Remove unused 3rd arg from Cli::Main cucumber/cucumber-ruby
1 participant
@aurelien-reeves