Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails destroy cucumber:feature deletes the steps folder, even though it's not empty. #111

Closed
anlek opened this issue Mar 22, 2011 · 4 comments

Comments

@anlek
Copy link

anlek commented Mar 22, 2011

Just wanted to let you know that I found a bug in the generator, where destroying the generator deletes the steps folder even though there are still files there.

rails g cucumber:feature account name:string 
       exist  features/step_definitions
      create  features/manage_accounts.feature
      create  features/step_definitions/account_steps.rb
        gsub  features/support/paths.rb
rails destroy cucumber:feature account                     
      remove  features/step_definitions
      remove  features/manage_accounts.feature
      remove  features/step_definitions/account_steps.rb

Please notice the first line in the destroy command: remove features/step_definitions

@aslakhellesoy
Copy link
Contributor

Thanks. This is the sort of bug that will only get fixed if someone sends me a pull request.

@anlek
Copy link
Author

anlek commented Mar 22, 2011

Understood, I'll see if I can give it a fix, however really busy at the moment.

@mblake
Copy link

mblake commented Jul 7, 2011

I initiated a pull request for this issue. I removed the empty_folder creation in the features generator, it doesn't seem to cause any problems if the folder doesn't exist as the creation of the step definition on generation creates the whole chain of folders if they do not exist.

@aslakhellesoy
Copy link
Contributor

Fixed in 1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants