NullPointerException in GuiceFactory masks root cause

[chriseldredge]

👓 What did you see?

Using Cucumber JVM with my own implementation of InjectorSource, if my Guice modules are misconfigured and the injector fails to initialize, a runtime exception is thrown with root cause details (e.g. missing binding for a required interface).

However, when this happens, GuiceFactory.stop() gets invoked by Runner.disposeBackendWorlds() which is in turn invoked in a finally block in Runner.runPickle().

GuiceFactory.stop needs a null check to avoid NullPointerException, but the cleanup code in Runner should ideally also suppress exceptions and add them to the root cause exception (using Throwable.addSuppressed).

✅ What did you expect to see?

The root cause exception

📦 Which tool/library version are you using?

testImplementation("io.cucumber:cucumber-guice:7.11.2")
testImplementation("io.cucumber:cucumber-java:7.11.2")
testImplementation("io.cucumber:cucumber-testng:7.11.2")

🔬 How could we reproduce it?

Steps to reproduce the behavior:

1. git clone https://github.com/chriseldredge/cucumber-guice-startup-exception-masked.git
2. cd cucumber-guice-startup-exception-masked
3. ./gradlew build
4. View failure error in ./lib/build/reports/tests/test/index.html

[mpkorstanje]

GuiceFactory.stop needs a null check to avoid NullPointerException

Agreed. Would you like to send a pull request for this?

the cleanup code in Runner should ideally also suppress exceptions and add them to the root cause exception (using Throwable.addSuppressed).

That's a bit trickier. I'll have to look for a good solution.