[Core] Delegate encoding and BOM handling to gherkin #2624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the
#encoding: <encoding>
comment.With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the
FeatureParser
doesn't take aInputStream
as an argument. So we need to add a default interface to avoid breaking semver.🏷️ What kind of change is this?
📋 Checklist: