Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing DataTableType convenience methods #1643

Closed
mpkorstanje opened this issue May 26, 2019 · 1 comment
Closed

Consider removing DataTableType convenience methods #1643

mpkorstanje opened this issue May 26, 2019 · 1 comment
Milestone
5.0.0

Comments

@mpkorstanje
Copy link
Contributor

Reducing the number of utility functions makes the API easier to understand/document/maintain.

Both DataTableType.cell and DataTableType.entry are mostly made spurious by DataTableTypeRegistry.setDefaultDataTableEntryTransformer and DataTableTypeRegistry.setDefaultDataTableCellTransformer.

For the few remaining use cases it would be better to explicitly define and configure the object mapper.

Also consider making DataTableType.transform package private.
@mpkorstanje mpkorstanje modified the milestones: 5.0.0, 4.x.x May 26, 2019
@mpkorstanje mpkorstanje reopened this Jun 15, 2019
@mpkorstanje mpkorstanje modified the milestones: 4.x.x, 5.0.0 Jun 15, 2019
@mpkorstanje mpkorstanje changed the title Consider deprecating DataTableType convenience methods Consider removing DataTableType convenience methods Jun 15, 2019
@mpkorstanje
Copy link
Contributor Author

Methods have been deprecated. Can be removed from datatable when we start with v5.

@mpkorstanje mpkorstanje mentioned this issue Aug 2, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@mpkorstanje