From e52fc4f0aeab12279b43df296cc0dd0d1d9824df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Rasmusson?= Date: Tue, 25 Jul 2017 13:46:31 +0200 Subject: [PATCH] [Core] Change return value to reduce duplication. --- .../src/main/java/cucumber/runtime/RuntimeOptions.java | 3 +-- .../java/cucumber/runtime/model/CucumberFeature.java | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/core/src/main/java/cucumber/runtime/RuntimeOptions.java b/core/src/main/java/cucumber/runtime/RuntimeOptions.java index d12b2c1dbf..2d884399b7 100644 --- a/core/src/main/java/cucumber/runtime/RuntimeOptions.java +++ b/core/src/main/java/cucumber/runtime/RuntimeOptions.java @@ -444,8 +444,7 @@ public Map> getLineFilters(ResourceLoader resourceLoader) { private void processRerunFiles(ResourceLoader resourceLoader) { for (String featurePath : featurePaths) { if (featurePath.startsWith("@")) { - for (String path : CucumberFeature.loadRerunFile(resourceLoader, featurePath.substring(1))) { - PathWithLines pathWithLines = new PathWithLines(path); + for (PathWithLines pathWithLines : CucumberFeature.loadRerunFile(resourceLoader, featurePath.substring(1))) { addLineFilters(lineFilters, pathWithLines.path, pathWithLines.lines); } } diff --git a/core/src/main/java/cucumber/runtime/model/CucumberFeature.java b/core/src/main/java/cucumber/runtime/model/CucumberFeature.java index dba75311c6..35f8ee23fa 100644 --- a/core/src/main/java/cucumber/runtime/model/CucumberFeature.java +++ b/core/src/main/java/cucumber/runtime/model/CucumberFeature.java @@ -55,20 +55,20 @@ public static List load(ResourceLoader resourceLoader, List loadRerunFile(ResourceLoader resourceLoader, String rerunPath) { - List featurePaths = new ArrayList(); + public static List loadRerunFile(ResourceLoader resourceLoader, String rerunPath) { + List featurePaths = new ArrayList(); Iterable resources = resourceLoader.resources(rerunPath, null); for (Resource resource : resources) { String source = read(resource); if (!source.isEmpty()) { Matcher matcher = RERUN_PATH_SPECIFICATION.matcher(source); while(matcher.find()){ - featurePaths.add(matcher.group(1)); + featurePaths.add(new PathWithLines(matcher.group(1))); } } }