Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load custom snippet syntax by relative path only if it begins with a dot #1640

Closed
charlierudolph opened this issue Apr 13, 2021 · 2 comments · Fixed by #1812
Closed

Load custom snippet syntax by relative path only if it begins with a dot #1640

charlierudolph opened this issue Apr 13, 2021 · 2 comments · Fixed by #1812
Assignees
Labels
💔 breaking change This will require a major release
Milestone

Comments

@charlierudolph
Copy link
Member

charlierudolph commented Apr 13, 2021

Want to implement something similar to #1413 for snippet syntax.


The above-mentioned change made referencing custom formatters a lot more logical. Before:

# an npm package
--format node_modules/some-formatter-package/index.js

# a project-local file
--format formatter.js

After:

# an npm package
--format some-formatter-package

# a project-local file
--format ./formatter.js

We want it to work the same way for custom snippet syntaxes, but it's technically a breaking change so should probably wait for 8.0.0.

@charlierudolph charlierudolph mentioned this issue Apr 13, 2021
9 tasks
@aurelien-reeves
Copy link
Contributor

@charlierudolph may I let you qualify that issue using labels?

Also if you could add some context and/or description, that would be great 😄

@davidjgoss davidjgoss added the 💔 breaking change This will require a major release label Apr 22, 2021
@davidjgoss davidjgoss added this to the 8.0.0 milestone Apr 22, 2021
@davidjgoss
Copy link
Contributor

@aurelien-reeves updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 breaking change This will require a major release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants