-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on node:util
and window
#1752
Merged
aslakhellesoy
merged 7 commits into
main
from
cucumber-expressions-remove-generate-expression
Sep 15, 2021
Merged
Remove dependency on node:util
and window
#1752
aslakhellesoy
merged 7 commits into
main
from
cucumber-expressions-remove-generate-expression
Sep 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
changed the title
Remove deprecated generateExpression method
Remove dependency on Sep 14, 2021
node:util
aslakhellesoy
changed the title
Remove dependency on
Remove dependency on Sep 14, 2021
node:util
node:util
and window
aslakhellesoy
added
🐛 bug
Defect / Bug
🔧 build
Related to build / release process
labels
Sep 14, 2021
aurelien-reeves
approved these changes
Sep 15, 2021
@@ -11,10 +11,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
### Changed | |||
|
|||
* Remove dependency on Node.js APIs (`util` module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Remove dependency on Node.js APIs (`util` module) | |
* Remove dependency on Node.js APIs (`util` module) | |
([#1752](https://github.com/cucumber/common/pull/1752)) |
Co-authored-by: Aurélien Reeves <[email protected]>
Co-authored-by: Aurélien Reeves <[email protected]>
aslakhellesoy
deleted the
cucumber-expressions-remove-generate-expression
branch
September 15, 2021 08:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove dependency on Node.js and Browser APIs
Details
We were depending on
util
in a couple of places:util.deprecate
was used to deprecate theCucumberExpressionGenerator#generateExpression()
method.util.format
was used to build generated Cucumber expressions (from undefined steps).We were depending on
window
in a file that wasn't used or exposed in the exports.All of this has been removed. In the process the deprecated
CucumberExpressionGenerator#generateExpression()
method has also been removed. For consistency the RubyCucumberExpressionGenerator#generate_expression
method has also been removed. No changes were needed in the Go and Java implementation (the deprecated method was not present).Finally, a couple of obsolete
module.exports
assignments have also been removed.Motivation and Context
The use of the Node.js
util
module causes a build error when esbuild is used to build a project that depends on this library:How Has This Been Tested?
With Mocha :-)
Types of changes
Checklist: