Cannot set fail_on_error with run_simple

[mikepack]

The logic here will always result in true. ie:

run_simple('cmd', false)
# leads to...
false || true #=> true

run_simple('cmd', true)
# leads to...
true || true #=> true

Sorry, don't have time to submit a PR right now, but wanted to report after upgrading to 0.11.x.

[ghost]

@mikepack Yeah, thanks. Will have a look at this. Unfortunately I'm a little bit out of time as well. So it may take some time until I can fix that.

[mikepack]

No problem. I worked around it by switching to the option hash style:

run_simple('cmd', fail_on_error: false)

[ghost]

Ah. Ok. Then it's a bug I introduced with my last changes. Damn.

[mikepack]

🍻 thanks for all your work on Aruba!

[ghost]

:-)

[ghost]

I hope I fixed the issue in master, can you please verify that?

[mikepack]

Fixed!

[ghost]

Ok. 0.11.2 is out now. Can you check that as well? Thanks a lot.

[mikepack]

Works like a charm.

[ghost]

Great. Thanks for the feedback.