Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve development environment #240

Merged
merged 12 commits into from May 11, 2015
Merged

Improve development environment #240

merged 12 commits into from May 11, 2015

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2015

  1. Remove ruby 1.9.3 from supported rubies

    Ruby 1.9.3 is End of Life. I see no reason to officially support a ruby
    version which does not get any bugfixes from core developers.

  2. Add support for JRuby 2 and 2.1 mode

  3. Debugging

    pry seems to be the debugger-tool in the ruby-world. Together with byebug
    (ruby 2 only) even code walking is possible. The stack_explorer plugin gives
    you a nice access to the stack trace. The doc-plugin makes ruby doc available from within a pry session

  4. License Finder

    aruba seems be used widely. So extra care should be taken with licensing
    issues. The license_finder helps
    you with that. It tracks license of all uses libraries. I whitelisted the MIT
    and the BSD-licenses, I think there's no problem here. I excluded the gems
    which are part of the development-group. They are not needed for the
    core-functionality.

@jarl-dk @mattwynne Feedback?

@mattwynne
Copy link
Member

This is great. I suggest you update https://github.com/cucumber/aruba/blob/master/CONTRIBUTING.md to explain how to use the bootstrap and test scripts, then merge it in.

@mattwynne
Copy link
Member

Thinking about it, I'm not sure why we need script/test - I think the default should be just to run bundle exec rake

@ghost
Copy link
Author

ghost commented May 7, 2015

There was a talk from a guy from github. Using script/* can be used in projects using different languages whereas bundle exec rake is ruby specific.

@ghost
Copy link
Author

ghost commented May 7, 2015

It's more a convience thing, that other developers do not need to think about running rake test or rake test:rspec or ... but hey there's a /script/test let's run this script to run tests.

@mattwynne
Copy link
Member

mattwynne commented May 7, 2015 via email

@ghost
Copy link
Author

ghost commented May 7, 2015

Rebased, added documentation and make use of the bootstrap script on travis to make sure it really works.

@mattwynne
Copy link
Member

mattwynne commented May 7, 2015 via email

@ghost
Copy link
Author

ghost commented May 8, 2015

Access Denied.

@maxmeyer maxmeyer merged commit 252a8b5 into cucumber:master May 11, 2015
@maxmeyer
Copy link
Member

Ok. Done.

@mattwynne
Copy link
Member

mattwynne commented May 12, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants