Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in systolic array data processing #3

Closed
sgpthomas opened this issue Dec 14, 2020 · 1 comment
Closed

Bug in systolic array data processing #3

sgpthomas opened this issue Dec 14, 2020 · 1 comment

Comments

@sgpthomas
Copy link
Collaborator

In this file, there is a bug with how we process the systolic array data.

We gathered data on gemm sizes for 1x1 to 8x8. However, we only report the even sizes: 2x2, 4x4, 6x6, 8x8.
We implement this by filtering out the unwanted data from the pandas dataframe.

# Remove systolic array data for which VHLS implementation failed
systolic_data = systolic_data.drop([0, 4, 6]).reset_index(drop=True)
systolic_data['latency'] = systolic_lat['latency']

The bug with this code is that we filter the data frame before merging it. Pandas doesn't merge by keys, so it merged
the wrong latency information for each benchmark name. For example the benchmark 4x4 got the latency for 3x3.

@rachitnigam
Copy link
Member

We caught this bug during ASPLOS 2021 artifact evaluation and fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants