Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly broad WCA OAuth scope? #3

Closed
jfly opened this issue Mar 30, 2021 · 1 comment
Closed

Overly broad WCA OAuth scope? #3

jfly opened this issue Mar 30, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jfly
Copy link
Member

jfly commented Mar 30, 2021

There's an oauth url with a scope defined in a few places in this repo:

All of those have scope=public+dob+email+manage_competitions. Do you really need dob and manage_competitions? If you do, it would be nice to have an explanation of why when I log in.

Neat project, btw! I look forward to learning more about it =)

@big213
Copy link
Member

big213 commented Mar 30, 2021

Fair point, and thanks for bringing this to my attention. I guess the dob and manage_competitions scopes are not really needed, I think they were added because I just copy and pasted that part from some other project that did use them. Anyway, I will get these references removed in the next release.

@big213 big213 added the enhancement New feature or request label Mar 30, 2021
@big213 big213 closed this as completed in 702b82e Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants