Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some WebAdmin tabs are broken #249

Closed
NiLSPACE opened this issue Sep 4, 2022 · 1 comment
Closed

Some WebAdmin tabs are broken #249

NiLSPACE opened this issue Sep 4, 2022 · 1 comment
Labels

Comments

@NiLSPACE
Copy link
Member

NiLSPACE commented Sep 4, 2022

After 864e351 some webadmin tabs are broken. The commit made URLs partially lower-case while the Javascript/HTML is still using PascalCase.

I see 3 ways to fix this. We could:

  • Change everything back to PascalCase / the original URLs
  • Make everything snake-case. This would also require us to look into all the html and javascript code.
  • Change Cuberite itself to make the URLs case-insensitive.

I personally prefer the first one. URLs now have mixed casings in it because the name of the plugin itself is also used in the URL.

@NiLSPACE NiLSPACE added the bug label Sep 4, 2022
@mathiascode
Copy link
Member

Thanks for the bug report. I wasn't aware some URLs were hardcoded.

I used the same URL format as the Gallery plugin, since @madmaxoft made that change (cuberite/gallery@146f8e3) and also introduced cWebAdmin:AddWebTab in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants