New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed benchmarks vs scipy #26

Open

ogencoglu opened this issue Oct 13, 2024 · 2 comments

ogencoglu commented Oct 13, 2024 •

edited

Loading

And speed benchmarks vs scipy / opencv / scikit-image for convex hull?

Member

district10 commented Dec 5, 2024

No. This is mainly about concave hull. The convex hull implemented here is only for minimal dependency (we used to depend on scipy convex hull).

Member

district10 commented Dec 15, 2024

There's a bug in convex hull generation in version 0.0.6~0.0.8 (seems only on macOS and windows, I'm not quite sure).

So the https://github.com/cubao/concave_hull/blob/master/src/convex_hull.hpp (cp-algorithms/grahams-scan version is replaced by https://github.com/cubao/concave_hull/blob/master/src/convex_hull2.hpp (just like what mapbox/cancaveman did).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment