Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in PanelList.render(): #79

Closed
webdevsyd opened this issue Mar 14, 2018 · 5 comments · Fixed by #84
Closed

Error in PanelList.render(): #79

webdevsyd opened this issue Mar 14, 2018 · 5 comments · Fixed by #84

Comments

@webdevsyd
Copy link

Hi @ctxhou I'm getting an error when I try to put the code from this link https://github.com/ctxhou/react-tabtab/blob/master/docs/components/Basic.js to my project component. I'm currently using "react": "^15.4.0", as per you readme.md your component supports react v15.

screen shot 2018-03-14 at 8 12 12 pm

@ctxhou
Copy link
Owner

ctxhou commented Mar 14, 2018

Hi @webdevsyd,
Thanks for your report.
I will figure out what happened recently.

@webdevsyd
Copy link
Author

Thank you @ctxhou hope you can fix it so I can use your component

@ctxhou
Copy link
Owner

ctxhou commented Mar 15, 2018

@webdevsyd I've fixed it in #81 pr.

Please install v1.3.0 and try it.

@webdevsyd
Copy link
Author

webdevsyd commented Mar 26, 2018

Hey @ctxhou I installed v1.3.1

if <Panel> is more than 1, same error as above is displayed

<Tabs>
            <TabList>
              <Tab>Tab1</Tab>
            </TabList>
            <PanelList>
              <Panel>Content1</Panel>
              <Panel>Content1</Panel>
            </PanelList>
          </Tabs>

If <Panel> is only 1, it displays this error children.map is not a function

@ctxhou
Copy link
Owner

ctxhou commented Mar 26, 2018

Hi @webdevsyd

Really thanks for your report.

There are some issues I didn't notice of react v15.

I've fixed it and published in v1.4.0.

Please try it again, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants