-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag Tabs with close button issue on windows #147
Comments
I'm guessing my fix for this issue will also fix your issue: |
@willvoicebase I'm was using your exact custom files workaround for my app but now am running into an issue where with this stack trace I was wondering if you have encountered this problem yourself and if you know a solution since this removes the ability to have a custom workaround delay |
I want a dot like option inside my each draggable tab so i passed it as an children to drag
<DragTab>
with dots on click of which I want to show a popover which shows an option of renaming and deleting that tab. But when I click the dots popover open but at the same time tab becomes draggable which I don't want when I click the dots.
I have tried mouse down up click but nothing works properly and on
windows
theexample
to does not work properly but inmac
it works.https://ctxhou.github.io/react-tabtab/#complicated
Here is my code:
tabsTemplate.push( <DragTab key={index}> {tab.title} <span className="dots" onMouseDown={e => this.handleJourneyOptions(e)}>...</span> {showOption ? <Popover open={showJourneyOptions} onClose={this.handleJourneyOptionsClose} anchorEl={journeyHeaderEl} anchorOrigin={{ vertical: 'center', horizontal: 'center', }} transformOrigin={{ vertical: 'top', horizontal: 'center', }} > <JourneyOptions> <span>Rename journey</span> <span className="deleteJourney" onClick={() => this.handleDeleteJourney({type: 'delete', index: index})} >Delete journey</span> </JourneyOptions> </Popover> : null} </DragTab>, );
The text was updated successfully, but these errors were encountered: