Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "best practices for logging" vignette #113

Closed
pbchase opened this issue May 24, 2023 · 2 comments
Closed

Add "best practices for logging" vignette #113

pbchase opened this issue May 24, 2023 · 2 comments
Milestone
Update unnest_job...

Comments

@pbchase
Copy link
Contributor

pbchase commented May 24, 2023

Add a vignette providing best practices for logging and the job_summary_data field. This relates to unnest_job_summary_data_json_object() and PR #111. That function is limited by choices developers make during logging. We want to help them make better choices.

The issue arises when two objects in the log data have different row/member counts. The purrr functions can't reconcile the different number of repeats. To avoid this, all objects should have length 1 and/or N. Do not include a third length or a second length that does not equal 1.
@pbchase pbchase mentioned this issue May 24, 2023
Open
@pbchase
Copy link
Contributor Author

pbchase commented Oct 24, 2023

Added vignette in 66da3a8

@pbchase pbchase mentioned this issue Oct 24, 2023
Merged
@pbchase
Copy link
Contributor Author

pbchase commented Nov 17, 2023

Addressed by PR #115

@pbchase pbchase closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Update unnest_job_summary_data_json_o...
Development

No branches or pull requests
1 participant
@pbchase