Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass size to component #80

Open
bradennapier opened this issue May 2, 2017 · 1 comment
Open

Always pass size to component #80

bradennapier opened this issue May 2, 2017 · 1 comment

Comments

@bradennapier
Copy link

Hey!
Love the this - great tool thanks as always -- pretty sure I use more of your packages than anyones. :)

Anyway, so the issue I have is that if you return height/width with the query then you will always update - losing the benefit of this component completely. However, when it does render I still need the measured height/width to operate styles etc based upon it. I think in that sense we should always get the height/width props sent down -- or perhaps at least allow us to request this action via a configuration prop?

@bradennapier
Copy link
Author

Pull Request created!
#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant