Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Clarify AllowedChars vs. DeniedCharactersRegex in README #24

Closed
larskn opened this issue Feb 1, 2021 · 1 comment · Fixed by #51
Closed

[documentation] Clarify AllowedChars vs. DeniedCharactersRegex in README #24

larskn opened this issue Feb 1, 2021 · 1 comment · Fixed by #51

Comments

@larskn
Copy link

larskn commented Feb 1, 2021

The README states that the default config is DeniedCharactersRegex = @"[^a-zA-Z0-9\-\._]"; but looking at the source code this is not true, the default setting is a list of AllowedChars (it matches the specified regex but it is a difference, which I discovered while looking into #22 ). I think this should be clarified.

Also I noticed that in the unit tests the DeniedCharactersRegex is labeled as "Legacy".
Is AllowedChars now there preferred way of configuration?
The README doesn't mention AllowedChars at all.

@ctolkien
Copy link
Owner

ctolkien commented Feb 1, 2021

I suspect we've broken this in the migration to V3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants