Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerance on audio playback duration #132

Open
yanj-github opened this issue Nov 22, 2023 · 2 comments
Open

tolerance on audio playback duration #132

yanj-github opened this issue Nov 22, 2023 · 2 comments
Labels
Deferred Deferred to future work.

Comments

@yanj-github
Copy link
Contributor

Driven from issue #118
tolerance on video playback duration will be changed from 20ms to 50ms for video.
At the moment the duration tolerance is shared both by audio and video observations and this change is going to impact to audio as well.
It might be better to separate out the tolerance for audio, which might require different value.
For video we are capturing every 8.33ms (on 120fps) so there will be a difference between captured time vs where the frame actually appeared.
Audio is different, it is captured accurately with a little difference (couple of milliseconds).
We will need to run more tests on the device to work out what tolerance we need on audio duration check, but what I can see so far is that 20ms for audio duration passes most of the test.

@gitwjr gitwjr added the BETA The test(s) addressed by this issue will be labeled Beta label Dec 5, 2023
@jpiesing jpiesing added the Release V2 Deferred to Release V2 label Feb 7, 2024
@jpiesing
Copy link

Feb 20th meeting
Expect to be within 20ms based on the way we measure audio. 50ms is also OK.
Parameter is purely an observation & doesn't impact test observation.

@FritzHeiden Please consider including perhaps 2 audio tests in what is run at the HbbTV plugfest so we have some data to evaluate this.

@jpiesing
Copy link

jpiesing commented Mar 5, 2024

March 5th meeting
Discussion

  • 50ms brings a risk of passing something that should fail
  • 20ms would reduce the risk of passing something that should fail
  • 10ms would be possible to measure

If we change it to 20ms, do we risk breaking anything? Requires work on both test runner and OF as tolerance is common for both video and audio.

There's probably more useful things for people to be doing.

@jpiesing jpiesing added Deferred Deferred to future work. and removed Release V2 Deferred to Release V2 BETA The test(s) addressed by this issue will be labeled Beta labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deferred Deferred to future work.
Projects
None yet
Development

No branches or pull requests

3 participants