Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creation of aac audio tests #111

Closed
jpiesing opened this issue May 8, 2023 · 24 comments
Closed

creation of aac audio tests #111

jpiesing opened this issue May 8, 2023 · 24 comments
Assignees
Labels
Release V2 Deferred to Release V2

Comments

@jpiesing
Copy link

jpiesing commented May 8, 2023

This issue is for the creation of the HTML+JS code for the AAC audio tests - referencing the new AAC test content as follows;

http://dash-large-files.akamaized.net/WAVE/vectors/releases/1/

e.g. http://dash-large-files.akamaized.net/WAVE/vectors/releases/1/caaa_sets/aac_lc/at8/2023-04-27/stream.mpd

@yanj-github @rcottingham Please can you help @FritzHeiden with any additional information he needs.

@FritzHeiden
Copy link
Collaborator

I would need some matrix matching audio content with test template to generate the audio tests from

@rcottingham
Copy link

Matrix attached CTA WAVE_AAC Matix_20230428.xlsx. Note:

  • chunked audio content not yet created
  • splicing content/tests for Resillion development purposes only at this stage

Note, Resillion are responsible to generate audio tests for 8.2-8.14 (excluding 8.5 as out of scope).
Fraunhofer to generate Section 9 tests.

@DannyKokkinos
Copy link

Pull request for the aac tests has been made: #112
@FritzHeiden @louaybassbouss

@FritzHeiden
Copy link
Collaborator

Tests are generated in the temporary feature branch, which will be merged once all tests properly work with the new content
https://github.com/cta-wave/dpctf-tests/commits/content-2023-04-28

@yanj-github
Copy link
Contributor

@FritzHeiden Thanks for getting this done.
Just a quick comment on those section 9 tests:

  • 9.2 Regular Playback of a CMAF Presentation
  • 9.3 Random Access of a WAVE Presentation
  • 9.4 Splicing of WAVE Program with Baseline Constraints

I think, we need to add the audio to exsiting video test not create a new test.
For example:
"regular-playback-of-a-cmaf-presentation","https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2023-04-28/stream.mpd","https://dash.akamaized.net/WAVE/vectors/releases/1/caac_sets/aac_lc/at1/2023-04-27/stream.mpd","cfhd_15_30_60-online"

And remove:
"regular-playback-of-a-cmaf-presentation","","https://dash.akamaized.net/WAVE/vectors/releases/1/caac_sets/aac_lc/at1/2023-04-27/stream.mpd","caac_sets-online"

@yanj-github
Copy link
Contributor

I think is it useful to link another issue to this one as they are related.
cta-wave/Test-Content-Generation#62

@FritzHeiden
Copy link
Collaborator

I think, we need to add the audio to exsiting video test not create a new test.

I updated the tests accordingly. In case of test 9.4, the audio and video segments are not in line, which is expected to cause issue with the audio

@yanj-github
Copy link
Contributor

yanj-github commented May 23, 2023

I updated the tests accordingly. In case of test 9.4, the audio and video segments are not in line, which is expected to cause issue with the audio

@FritzHeiden cta-wave/device-playback-task-force#111
is still open for discussion. As far as I understand audio should match video playout. But correct me if I am wrong. Audio playback for 9.4 was not clearly defined on the spec.

@FritzHeiden
Copy link
Collaborator

The audio tests are now merged to master

@yanj-github
Copy link
Contributor

@FritzHeiden will you be able to merge playback-over-wave-baseline-splice to have:

9.4 Splicing of WAVE Program with Baseline Constraints:

  • video: cfhd_sets/12.5_25_50/splice_main cfhd_sets/12.5_25_50/splice_ad
  • audio: caac_sets/aac_lc/at13 caac_sets/aac_lc/at14

@gitwjr
Copy link

gitwjr commented Jun 6, 2023

Relates to DPCTF Tests #110 . This is on @FritzHeiden list of tasks when checking splicing tests.
Also relates to cta-wave/Test-Content#19

@gitwjr
Copy link

gitwjr commented Jun 6, 2023

@FritzHeiden to provide recordings to @rcottingham

@FritzHeiden
Copy link
Collaborator

@FritzHeiden will you be able to merge playback-over-wave-baseline-splice to have:

9.4 Splicing of WAVE Program with Baseline Constraints:

* video: cfhd_sets/12.5_25_50/splice_main   cfhd_sets/12.5_25_50/splice_ad

* audio: caac_sets/aac_lc/at13   caac_sets/aac_lc/at14

This is now available in master

@yanj-github
Copy link
Contributor

Thanks @FritzHeiden are these new audio tests and video audio combined tests been tested and validated on your end please?

@FritzHeiden
Copy link
Collaborator

Yes they are. I will provide a recording

@FritzHeiden
Copy link
Collaborator

@rcottingham
Copy link

Unfortunately, recording does not have audio so unable to run through Observation Framework

@gitwjr
Copy link

gitwjr commented Jun 20, 2023

See also DPCTF-Tests Issue #110 unclear if audio not recorded or just missing.

@gitwjr gitwjr added the Deferred Deferred to future work. label Aug 1, 2023
@gitwjr
Copy link

gitwjr commented Aug 1, 2023

Not in Launch.

@FritzHeiden
Copy link
Collaborator

@rcottingham recordings can be found here: https://drive.google.com/file/d/16U1A8A53zt-B532NOkZnOdX4lzOT6Spe/view?usp=sharing

Unfortunately, recording does not have audio so unable to run through Observation Framework

When I download the linked recordings there is audio present in the video. Could you specify what exactly is the problem?

@gitwjr gitwjr added the Release V2 Deferred to Release V2 label Aug 29, 2023
@yanj-github
Copy link
Contributor

@jpiesing can we close this issue as now we have aac audio tests generated, also Dolby audio is available.

@jpiesing jpiesing removed the Deferred Deferred to future work. label Feb 13, 2024
@jpiesing
Copy link
Author

@yanj-github I'm OK with closing this. Are you still confident there's nothing left to do under this issue?

@yanj-github
Copy link
Contributor

@jpiesing yes please feel free to close this issue. we have issue with 9.4 but we have separate issue created for 9.4 test in general.

@jpiesing
Copy link
Author

Closing as agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release V2 Deferred to Release V2
Projects
None yet
Development

No branches or pull requests

6 participants