You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently started giving it a shot, and I noticed that traits are not localized, and they're not filtering correctly. From a glance, at the codebase, it seems that you're comparing the values rather than the keys, which will lead to problems with localizations as well.
You can use Object.entries() to have the traits be a list of [key, value] and compare on those, or use keys throughout and fetch it from the actual trait object (game.i18n.localize(CONFIG.PF2E.weaponTraits[trait])).
The text was updated successfully, but these errors were encountered:
Recently started giving it a shot, and I noticed that traits are not localized, and they're not filtering correctly. From a glance, at the codebase, it seems that you're comparing the values rather than the keys, which will lead to problems with localizations as well.
You can use Object.entries() to have the traits be a list of [key, value] and compare on those, or use keys throughout and fetch it from the actual trait object (
game.i18n.localize(CONFIG.PF2E.weaponTraits[trait])
).The text was updated successfully, but these errors were encountered: