Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with PF2e #11

Open
CarlosFdez opened this issue Sep 2, 2021 · 0 comments
Open

Incompatibility with PF2e #11

CarlosFdez opened this issue Sep 2, 2021 · 0 comments

Comments

@CarlosFdez
Copy link

Recently started giving it a shot, and I noticed that traits are not localized, and they're not filtering correctly. From a glance, at the codebase, it seems that you're comparing the values rather than the keys, which will lead to problems with localizations as well.

You can use Object.entries() to have the traits be a list of [key, value] and compare on those, or use keys throughout and fetch it from the actual trait object (game.i18n.localize(CONFIG.PF2E.weaponTraits[trait])).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant