Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused ember-test-selectors dependency #408

Closed
guidojw opened this issue Dec 10, 2021 · 1 comment
Closed

Unused ember-test-selectors dependency #408

guidojw opened this issue Dec 10, 2021 · 1 comment

Comments

@guidojw
Copy link
Member

guidojw commented Dec 10, 2021

With merging #398, I noticed that we aren't really using this dependency at the moment. There are quite a few data-test-* attributes set in the templates but the tests don't reference these. They were probably used in the acceptance tests we used to have, which were removed in a Ember.js update a while ago.

My proposal is to remove the dependency and attributes and reinstall/reconfigure it again when we need it someday.

@guidojw
Copy link
Member Author

guidojw commented May 11, 2022

#539 starts using it again

@guidojw guidojw closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant