Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lamejs dependency #9

Closed
isolin opened this issue Dec 13, 2021 · 3 comments
Closed

Update lamejs dependency #9

isolin opened this issue Dec 13, 2021 · 3 comments

Comments

@isolin
Copy link

isolin commented Dec 13, 2021

Working with audio-encoder, I discovered an issue as described here. My colleague reported it and luckily the maintainer of lamejs package released a new version 1.2.1 to fix that.

It would be great if you could update the dependency to the most recent version (1.2.0 -> 1.2.1) so that I don't have to emulate the bugfix manually each time I build.

@isolin
Copy link
Author

isolin commented Dec 13, 2021

Update: Secondary issues arouse in lame.js. It will be better to wait for 1.2.2 to fix that.

@isolin
Copy link
Author

isolin commented Dec 13, 2021

Besides the issues in lame.js, I noticed the same type of issues with audio-encoder. I needed to add var in encodeMp3.js manually at lines 48, 49, 60 and 61 to flawlessly encode audio. It would be great if these could be updated for future compatibility. I created a pull request for that.

@cstoquer
Copy link
Owner

I updated lamejs version to 1.2.1 and published audio-encoder on npm with version 1.0.3.
Once a new version of lamejs is released, please reopen this issue and I'll update again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants