Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_hasmethod #1

Open
tshort opened this issue Apr 26, 2020 · 2 comments
Open

static_hasmethod #1

tshort opened this issue Apr 26, 2020 · 2 comments

Comments

@tshort
Copy link

tshort commented Apr 26, 2020

You might get a speed boost by using static_hasmethod from Tricks.jl.
@cstjean
Copy link
Owner

cstjean commented Apr 27, 2020

Thank you for the suggestion. I already have a fast version in https://github.com/cstjean/ConferenceCall.jl/blob/master/src/ConferenceCall.jl#L15-L21 that uses generated function (which I believe would be similar to Tricks.jl?) but generated functions are unfortunately not Reviseable, so I didn't want this to be the default. The linked PR JuliaLang/julia#32732 is a nice rabbit hole! I can't tell if Tricks.jl is actually world-age correct or if it might fail to Revise properly.

@tshort
Copy link
Author

tshort commented Apr 27, 2020

The main trick in static_hasmethod is attaching into the method table, so it updates as you define new methods. For that reason, I suspect that Tricks.jl is "Reviseable," but I didn't check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tshort @cstjean