Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic values update issue #1118

Closed
oliviertassinari opened this issue Jun 10, 2019 · 6 comments
Closed

Dynamic values update issue #1118

oliviertassinari opened this issue Jun 10, 2019 · 6 comments
Labels
bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up!

Comments

@oliviertassinari
Copy link
Contributor

Expected behavior:
Dynamic values should update.

Describe the bug:
Dynamic values don't update.

Codesandbox link:
https://codesandbox.io/s/material-demo-xivoe

const styles = {
  root: props => ({
    "@media print": {
      display: props.print
    }
  })
};

Versions (please complete the following information):

@kof
Copy link
Member

kof commented Jun 10, 2019

This specifically happens with media queries. I can see that instead of updating the media query, it creates a new empty one.

cc @HenriBeck it might be related to the issue we have seen with styled-system and duplicated media queries.

@kof kof added bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up! labels Jun 10, 2019
@HenriBeck
Copy link
Member

yeah, basically we would need to remove the old one. I think in general there is an issue with creating nested rules inside dynamic rules

@bardouni
Copy link

Hi
I have the same issue
when I log the sheet output using (sheet.toString) it shows a valid value :
image
but when I check the element's css from the inspector, it dosen't show the media query rules

@HenriBeck
Copy link
Member

@bardouni can you provide a codesandbox so we can check your code?

Usually, there is an alternative syntax where the issue doesn't exist

@HenriBeck
Copy link
Member

This also might be fixed with #1144

@kof
Copy link
Member

kof commented Dec 28, 2019

fixed in #1242, releasing in 10.0.1

@kof kof closed this as completed Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up!
Projects
None yet
Development

No branches or pull requests

4 participants