Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the schedule on SC has no effect #665

Closed
black-dragon74 opened this issue Sep 12, 2024 · 1 comment
Closed

Updating the schedule on SC has no effect #665

black-dragon74 opened this issue Sep 12, 2024 · 1 comment
Assignees

Comments

@black-dragon74
Copy link
Member

black-dragon74 commented Sep 12, 2024

For ReclaimSpace and EncryptionKeyRotation if the schedule is updated on the StorageClass, the new schedule is not reflected on the PVC since:

  • We do not check the value of the annotation in SC event handler, if the annotation is already present on PVC, we do not reconcile it.
  • Even if we trigger a reconcile for the PVC somehow, the updated schedule from SC is never read since we read first from the PVC.

The aim is to:

  • Update the StorageClass event handler so that along with checking for missing annotation from the PVC it also checks if the value between them differs, if so, a reconcile should be triggered.
  • The parsing of schedule should be modified to follow the precedence: Namespace > StorageClass > PVC
  • While updating an existing CR, we should update the schedule annotation with the new value
@black-dragon74 black-dragon74 self-assigned this Sep 12, 2024
@black-dragon74
Copy link
Member Author

Completed at: #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant