Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReclaimSpaceJob (and potentially others) failing creation on Kubernetes 1.28+ #623

Closed
psy-q opened this issue Jul 24, 2024 · 0 comments · Fixed by #625
Closed

ReclaimSpaceJob (and potentially others) failing creation on Kubernetes 1.28+ #623

psy-q opened this issue Jul 24, 2024 · 0 comments · Fixed by #625

Comments

@psy-q
Copy link

psy-q commented Jul 24, 2024 •
edited
Loading

When running on OKD, creating a ReclaimSpaceJob fails with:

Failed to make node request: failed to convert Kubernetes minor version "28+" to int: strconv.Atoi: parsing "28+": invalid syntax

The versions given are:

Client Version: 4.14.6
Kustomize Version: v5.0.1
Server Version: 4.15.0-0.okd-2024-02-10-035534
Kubernetes Version: v1.28.2-3572+f1618d54a81f9f-dirty

The type conversion may be too primitive to catch all kinds of Kubernetes version, perhaps a SemVer library should be used instead.
@psy-q psy-q changed the title ReclaimSpaceJob (and others) failing on Kubernetes 1.28+ ReclaimSpaceJob (and potentially others) failing creation on Kubernetes 1.28+ Jul 24, 2024
@psy-q psy-q mentioned this issue Jul 25, 2024
Merged
@mergify mergify bot closed this as completed in #625 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove special handling of targetpath for deprecated Kubernetes 1.24 psy-q/kubernetes-csi-addons
1 participant
@psy-q