Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version flag for csi-addons-sidecar #377

Closed
saranyareddy24 opened this issue Jun 21, 2023 · 3 comments · Fixed by #385
Closed

Add version flag for csi-addons-sidecar #377

saranyareddy24 opened this issue Jun 21, 2023 · 3 comments · Fixed by #385
Assignees
@saranyareddy24
Labels
good first issue Good for newcomers

Comments

@saranyareddy24
Copy link
Contributor

Other than currents flags in /usr/bin/csi-addons-sidecar, need a new flag which displays version -version.

It will be helpful in our case, where we are building pipelines for image creation of csi-addons components, once the image is built, if we have the version displayed, it will be easy to add that as a verification step in pipeline.
@Madhu-1 Madhu-1 added the good first issue Good for newcomers label Jun 21, 2023
@Madhu-1
Copy link
Member

Madhu-1 commented Jun 21, 2023

Looks like a good suggestion. added good-first-issue

@Madhu-1
Copy link
Member

Madhu-1 commented Jun 21, 2023

As add more details like below

  • Git commit, Go build,platform details

@saranyareddy24
Copy link
Contributor Author

I am working on it.

@saranyareddy24 saranyareddy24 mentioned this issue Jun 25, 2023
Merged
@mergify mergify bot closed this as completed in #385 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saranyareddy24 saranyareddy24

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding version details to sidecar saranyareddy24/kubernetes-csi-addons
2 participants
@Madhu-1 @saranyareddy24