Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reclaimspace: Add support for custom timeouts #348

Closed
Rakshith-R opened this issue May 8, 2023 · 2 comments · Fixed by #359
Closed

reclaimspace: Add support for custom timeouts #348

Rakshith-R opened this issue May 8, 2023 · 2 comments · Fixed by #359
Assignees
Labels
enhancement New feature or request

Comments

@Rakshith-R
Copy link
Member

Currently Reclaimspace requests to csi drivers use a default timeout of 3 min which can only be overridden from the cmdline args.

flag.DurationVar(&reclaimSpaceTimeout, "reclaim-space-timeout", defaultTimeout, "Timeout for reclaimspace operation")

The time taken by these cmds executed by csi drivers may vary significantly based on factors like size of the PVC, io pattern etc.

Therefore, having ability to override this timeout at reclaimspacejob CR per PVC level will be very useful.

@nixpanic @Madhu-1

@Rakshith-R Rakshith-R added the enhancement New feature or request label May 8, 2023
@Rakshith-R Rakshith-R self-assigned this May 8, 2023
@Madhu-1
Copy link
Member

Madhu-1 commented May 8, 2023

Yes, it should like a valid solution and we need to have some global configurations which can be changed as we dont expect to patch all the PVC with the same information (timeout).

@Madhu-1
Copy link
Member

Madhu-1 commented May 8, 2023

#347 cover this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants