CW2-25 Create "Contact-Us" page #13
Conversation
There was a problem hiding this comment.
Nice work to get started. Just a few cosmetic changes that might be good:
- you can remove the image Contact Us image I think, and just replace it with a Contact Us title (similar to some of the other pages)
- Would also be good to have an
iframeembed at the bottom like in the media page, I know its outdated but we will update later - I agree the text is probably too small, probably match the size on the media website, i think currenlty the first line of text under the image is smaller than the rest of it?
- Also get rid of the "Contact" in the text
- I think it also makes sense to move the big social media buttons from resources to contact us, don't think they really fit in "resources"
These should all be relatively quick changes. Also if you do feel something could be stylistically improved may as well try it out, you should have some freedom with the website
frontend/package.json
Outdated
There was a problem hiding this comment.
Do we need this change? (same with package-lock.json)
frontend/src/pages/contact-us.tsx
Outdated
| @@ -0,0 +1,68 @@ | |||
| import Footer from '@/components/Footer'; | |||
| import Hamburger from '@/components/Hamburger'; | |||
There was a problem hiding this comment.
I'm going to leave footer because its used in the page, ill remove hamburger though
| @@ -47,6 +47,9 @@ export default function Hamburger() { | |||
| <li className="py-2 text-lg"> | |||
| <Link href={'./sponsors'}>Sponsors</Link> | |||
| </li> | |||
| <li className="py-2 text-lg"> | |||
| <Link href={'./contact-us'}>Contact Us</Link> | |||
There was a problem hiding this comment.
Make it href={'./contact'} (similar to how it is called about-us but the url is just about) - will need to rename contact-us.tsx. Just so that the header text looks nicer
There was a problem hiding this comment.
Looking better, but still some small changes.
Look above at some of the comments I've left on specific lines for some small changes that are needed. (resolve the conversations once you've addressed them)
- I think make the embed smaller (in width, right now the embed is much wider than the actual form itself).
- Make sure there is some gap between the social media and the footer
Other than that, there are some more cosmetic changes we can make but can make it later ig
|
I've made the iframe smaller. I'm not sure how you'd like it alligned. It's alligned left to match with being under the text since fundamentally its a bit awkward to center. I've done everything else (relatively hastily but I believe I've covered everything). Let me know if theres anything else :) |
|
Merging this into the |
Why the changes are required?
Changes
Screenshots