Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration E-mail Verification #20

Closed
bensonchan opened this issue Oct 22, 2014 · 5 comments
Closed

Registration E-mail Verification #20

bensonchan opened this issue Oct 22, 2014 · 5 comments
Assignees
Labels

Comments

@bensonchan
Copy link
Contributor

Need to implement e-mail verification to validate e-mails. Will also extend Django User to be able to implement this and require e-mails on registration.

@bensonchan bensonchan self-assigned this Oct 22, 2014
@bensonchan bensonchan changed the title E-mail Verification Registration E-mail Verification Oct 22, 2014
@aleccool213
Copy link

I should extend this and verify if a user has confirmed there email on login. Or is that not needed?

@bensonchan
Copy link
Contributor Author

Basically, if a User has not confirmed their email, their is_active = False. According to https://docs.djangoproject.com/en/1.3/topics/auth/#django.contrib.auth.models.User.is_active it's not mandatory that is_active is checked. You can easily check it yourself if you want, and that would be all you need to do.

@aleccool213
Copy link

your stuff looks good though, merge it with master

@bensonchan
Copy link
Contributor Author

Not yet, need to fix up login and I think there's a small vulnerability somewhere. Will do all that and more tomorrow.

@bensonchan
Copy link
Contributor Author

I've patched up everything I could think of, awaiting one more check before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants