From f81613ff4933882e9c8884b0d50bc7eb8b35240a Mon Sep 17 00:00:00 2001 From: Thibaud Guillaume-Gentil Date: Sun, 15 Dec 2024 10:06:25 +0100 Subject: [PATCH] SVG, switch all to rails_icons gem This patch removes the `inline_svg` gem and moves all custom SVG icons to the `rails_icons` gem, with the `icon` helper. --- Gemfile | 1 - Gemfile.lock | 10 +++----- app/admin/delivery.rb | 24 +++++-------------- app/admin/depot.rb | 4 ++-- app/admin/invoice.rb | 4 ++-- app/admin/shop/order.rb | 8 ++----- app/admin/shop/special_delivery.rb | 14 +++-------- app/assets/images/admin/clipboard-check.svg | 3 --- app/assets/images/admin/clipboard.svg | 3 --- app/assets/images/admin/external-link.svg | 3 --- app/assets/images/logo.svg | 1 - app/assets/images/members/basket.svg | 1 - app/assets/images/members/calendar.svg | 1 - app/assets/images/members/cash.svg | 1 - app/assets/images/members/chevron_right.svg | 1 - app/assets/images/members/close.svg | 1 - .../images/members/document_download.svg | 1 - app/assets/images/members/globe.svg | 1 - app/assets/images/members/hand.svg | 1 - app/assets/images/members/identification.svg | 1 - app/assets/images/members/information.svg | 3 --- app/assets/images/members/link.svg | 1 - app/assets/images/members/mail.svg | 3 --- app/assets/images/members/map.svg | 1 - app/assets/images/members/menu.svg | 1 - app/assets/images/members/minus.svg | 1 - app/assets/images/members/notice.svg | 1 - app/assets/images/members/participant.svg | 1 - app/assets/images/members/pencil_square.svg | 3 --- app/assets/images/members/phone.svg | 1 - app/assets/images/members/plus.svg | 1 - app/assets/images/members/scale.svg | 1 - app/assets/images/members/shopping_cart.svg | 1 - app/assets/images/members/sign_out.svg | 1 - app/assets/images/members/trash.svg | 1 - app/assets/images/members/truck.svg | 1 - app/assets/images/members/user_circle.svg | 1 - app/assets/images/members/warning.svg | 1 - .../icons/own/file-csv.svg} | 0 .../icons/own/file-pdf.svg} | 0 .../icons/own/file-xlsx.svg} | 0 .../{images/admin => svg/icons/own}/logo.svg | 0 app/helpers/activities_helper.rb | 2 +- app/helpers/dashboard_helper.rb | 8 +++---- app/helpers/invoices_helper.rb | 2 +- app/helpers/links_helper.rb | 5 ++-- app/helpers/members_helper.rb | 2 +- app/views/active_admin/_site_footer.html.slim | 2 +- app/views/active_admin/_site_header.html.erb | 2 +- .../active_admin/page/_onboarding.html.arb | 12 +++++----- .../layouts/active_admin_logged_out.html.slim | 2 +- app/views/layouts/members/_flashes.html.slim | 4 ++-- app/views/layouts/members/_footer.html.slim | 15 ++++++------ app/views/layouts/members/_header.html.slim | 8 +++---- app/views/members/accounts/show.html.slim | 12 +++++----- .../_activity_participation.html.slim | 4 ++-- app/views/members/baskets/_basket.html.slim | 8 +++---- app/views/members/billing/_line.html.slim | 2 +- .../members/contact_sharings/show.html.slim | 6 ++--- app/views/members/members/_pricing.html.slim | 2 +- .../members/memberships/_membership.html.slim | 16 ++++++------- app/views/members/shop/orders/_cart.html.slim | 8 +++---- .../shop/orders/_finalized_order.html.slim | 4 ++-- .../members/shop/orders/_order.html.slim | 10 ++++---- app/views/members/shop/orders/show.html.slim | 2 +- .../members/shop/products/_product.html.slim | 2 +- .../members/shop/products/_variant.html.slim | 4 ++-- .../members/shop/products/index.html.slim | 2 +- spec/system/members/billing_spec.rb | 6 ++--- 69 files changed, 94 insertions(+), 166 deletions(-) delete mode 100644 app/assets/images/admin/clipboard-check.svg delete mode 100644 app/assets/images/admin/clipboard.svg delete mode 100644 app/assets/images/admin/external-link.svg delete mode 100644 app/assets/images/logo.svg delete mode 100644 app/assets/images/members/basket.svg delete mode 100644 app/assets/images/members/calendar.svg delete mode 100644 app/assets/images/members/cash.svg delete mode 100644 app/assets/images/members/chevron_right.svg delete mode 100644 app/assets/images/members/close.svg delete mode 100644 app/assets/images/members/document_download.svg delete mode 100644 app/assets/images/members/globe.svg delete mode 100644 app/assets/images/members/hand.svg delete mode 100644 app/assets/images/members/identification.svg delete mode 100644 app/assets/images/members/information.svg delete mode 100644 app/assets/images/members/link.svg delete mode 100644 app/assets/images/members/mail.svg delete mode 100644 app/assets/images/members/map.svg delete mode 100644 app/assets/images/members/menu.svg delete mode 100644 app/assets/images/members/minus.svg delete mode 100644 app/assets/images/members/notice.svg delete mode 100644 app/assets/images/members/participant.svg delete mode 100644 app/assets/images/members/pencil_square.svg delete mode 100644 app/assets/images/members/phone.svg delete mode 100644 app/assets/images/members/plus.svg delete mode 100644 app/assets/images/members/scale.svg delete mode 100644 app/assets/images/members/shopping_cart.svg delete mode 100644 app/assets/images/members/sign_out.svg delete mode 100644 app/assets/images/members/trash.svg delete mode 100644 app/assets/images/members/truck.svg delete mode 100644 app/assets/images/members/user_circle.svg delete mode 100644 app/assets/images/members/warning.svg rename app/assets/{images/admin/csv_file.svg => svg/icons/own/file-csv.svg} (100%) rename app/assets/{images/admin/pdf_file.svg => svg/icons/own/file-pdf.svg} (100%) rename app/assets/{images/admin/xlsx_file.svg => svg/icons/own/file-xlsx.svg} (100%) rename app/assets/{images/admin => svg/icons/own}/logo.svg (100%) diff --git a/Gemfile b/Gemfile index 86d39d806..1a93af4a5 100644 --- a/Gemfile +++ b/Gemfile @@ -36,7 +36,6 @@ gem "cancancan" gem "acts_as_list" gem "simple_form" -gem "inline_svg" gem "slim" gem "importmap-rails" diff --git a/Gemfile.lock b/Gemfile.lock index 3ab39f604..dde39f540 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -168,7 +168,7 @@ GEM crass (1.0.6) css_parser (1.21.0) addressable - csv (3.3.0) + csv (3.3.1) date (3.4.1) date_validator (0.12.0) activemodel (>= 3) @@ -264,9 +264,6 @@ GEM has_scope (>= 0.6) railties (>= 7.0) responders (>= 2) - inline_svg (1.10.0) - activesupport (>= 3.0) - nokogiri (>= 1.6) io-console (0.8.0) io-endpoint (0.14.0) io-event (1.7.4) @@ -512,7 +509,7 @@ GEM responders (3.1.1) actionpack (>= 5.2) railties (>= 5.2) - rexml (3.3.9) + rexml (3.4.0) rqrcode (2.2.0) chunky_png (~> 1.0) rqrcode_core (~> 1.0) @@ -595,7 +592,7 @@ GEM fugit (~> 1.11.0) railties (>= 7.1) thor (~> 1.3.1) - sorbet-runtime (0.5.11691) + sorbet-runtime (0.5.11694) sqlite3 (2.4.1) mini_portile2 (~> 2.8.0) sqlite3 (2.4.1-arm64-darwin) @@ -686,7 +683,6 @@ DEPENDENCIES icalendar image_processing importmap-rails - inline_svg kramdown launchy letter_opener diff --git a/app/admin/delivery.rb b/app/admin/delivery.rb index 8b0430d77..6ab31b2e6 100644 --- a/app/admin/delivery.rb +++ b/app/admin/delivery.rb @@ -40,21 +40,9 @@ column :shop, ->(delivery) { status_tag(delivery.shop_configured_open?) }, class: "text-right" end actions do |delivery| - div do - link_to baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv), title: "CSV" do - inline_svg_tag "admin/csv_file.svg", class: "w-5 h-5" - end - end - div do - link_to delivery_path(delivery, format: :xlsx), title: "XLSX" do - inline_svg_tag "admin/xlsx_file.svg", class: "w-5 h-5" - end - end - div do - link_to delivery_path(delivery, format: :pdf), target: "_blank", title: "PDF" do - inline_svg_tag "admin/pdf_file.svg", class: "w-5 h-5" - end - end + icon_file_link(:csv, baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv), title: Delivery.human_attribute_name(:summary), size: 5) + + icon_file_link(:xlsx, delivery_path(delivery, format: :xlsx), title: Delivery.human_attribute_name(:summary), size: 5) + + icon_file_link(:pdf, delivery_path(delivery, format: :pdf), target: "_blank", title: Delivery.human_attribute_name(:sheets), size: 5) end end @@ -84,9 +72,9 @@ columns do column do panel Basket.model_name.human(count: 2), action: ( - icon_link(:csv_file, Delivery.human_attribute_name(:summary), baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv)) + - icon_link(:xlsx_file, Delivery.human_attribute_name(:summary), delivery_path(delivery, format: :xlsx)) + - icon_link(:pdf_file, Delivery.human_attribute_name(:sheets), delivery_path(delivery, format: :pdf), target: "_blank") + icon_file_link(:csv, baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv), title: Delivery.human_attribute_name(:summary)) + + icon_file_link(:xlsx, delivery_path(delivery, format: :xlsx), title: Delivery.human_attribute_name(:summary)) + + icon_file_link(:pdf, delivery_path(delivery, format: :pdf), target: "_blank", title: Delivery.human_attribute_name(:sheets)) ) do counts = delivery.basket_counts if counts.present? diff --git a/app/admin/depot.rb b/app/admin/depot.rb index a2ce0e851..860e914a4 100644 --- a/app/admin/depot.rb +++ b/app/admin/depot.rb @@ -86,8 +86,8 @@ column do if next_delivery = depot.next_delivery panel t("active_admin.page.index.next_delivery", delivery: link_to(next_delivery.display_name(format: :long), next_delivery)).html_safe, action: ( - icon_link(:xlsx_file, Delivery.human_attribute_name(:summary), delivery_path(next_delivery, format: :xlsx, depot_id: depot.id)) + - icon_link(:pdf_file, Delivery.human_attribute_name(:sheets), delivery_path(next_delivery, format: :pdf, depot_id: depot.id), target: "_blank") + icon_file_link(:xlsx, delivery_path(next_delivery, format: :xlsx, depot_id: depot.id), title: Delivery.human_attribute_name(:summary)) + + icon_file_link(:pdf, delivery_path(next_delivery, format: :pdf, depot_id: depot.id), target: "_blank", title: Delivery.human_attribute_name(:sheets)) ) do attrs = {} if authorized?(:update, depot) && depot.delivery_sheets_mode == "home_delivery" diff --git a/app/admin/invoice.rb b/app/admin/invoice.rb index 628a2ec2f..f182a1ac8 100644 --- a/app/admin/invoice.rb +++ b/app/admin/invoice.rb @@ -181,7 +181,7 @@ end end unless invoice.processing? - panel "PDF", action: icon_link(:pdf_file, "PDF", pdf_invoice_path(invoice), target: "_blank") do + panel "PDF", action: icon_file_link(:pdf, pdf_invoice_path(invoice), target: "_blank") do div class: "p-2" do link_to_invoice_pdf(invoice) do image_tag invoice.pdf_file.preview(resize_to_limit: [ 2000, 2000 ]), class: "w-full" @@ -259,7 +259,7 @@ action_item :pdf, only: :show, if: -> { !resource.processing? } do link_to_invoice_pdf(resource, class: "action-item-button") do - "PDF" + icon "file-pdf", class: "h-5 w-5", library: "own" end end diff --git a/app/admin/shop/order.rb b/app/admin/shop/order.rb index 40092a961..8a370833c 100644 --- a/app/admin/shop/order.rb +++ b/app/admin/shop/order.rb @@ -285,17 +285,13 @@ action_item :delivery_pdf, only: :index, if: -> { params.dig(:q, :_delivery_gid_eq).present? } do delivery_gid = params.dig(:q, :_delivery_gid_eq) depot_id = params.dig(:q, :depot_id_eq) - link_to delivery_shop_orders_path(delivery_gid: delivery_gid, depot_id: depot_id, format: :pdf), class: "action-item-button", target: "_blank", title: t(".delivery_orders_pdf") do - inline_svg_tag "admin/pdf_file.svg", class: "w-5 h-5" - end + icon_file_link :pdf, delivery_shop_orders_path(delivery_gid: delivery_gid, depot_id: depot_id, format: :pdf), size: 5, class: "action-item-button", target: "_blank", title: t(".delivery_orders_pdf") end action_item :delivery_xlsx, only: :index, if: -> { params.dig(:q, :_delivery_gid_eq).present? } do delivery_gid = params.dig(:q, :_delivery_gid_eq) depot_id = params.dig(:q, :depot_id_eq) - link_to delivery_shop_orders_path(delivery_gid: delivery_gid, depot_id: depot_id, format: :xlsx), class: "action-item-button", target: "_blank", title: "XLSX" do - inline_svg_tag "admin/xlsx_file.svg", class: "w-5 h-5" - end + icon_file_link :xlsx, delivery_shop_orders_path(delivery_gid: delivery_gid, depot_id: depot_id, format: :xlsx), size: 5, class: "action-item-button", target: "_blank" end batch_action :invoice, if: ->(attr) { params[:scope].in?([ nil, "pending" ]) }, confirm: true do |selection| diff --git a/app/admin/shop/special_delivery.rb b/app/admin/shop/special_delivery.rb index 501a4f0af..2aff8b09a 100644 --- a/app/admin/shop/special_delivery.rb +++ b/app/admin/shop/special_delivery.rb @@ -56,16 +56,8 @@ q: { _delivery_gid_eq: d.gid }, scope: :all_without_cart)) }, sortable: false, class: "text-right" actions do |delivery| - div do - link_to shop_special_delivery_path(delivery, format: :xlsx), title: "XLSX" do - inline_svg_tag "admin/xlsx_file.svg", class: "h-5 w-5" - end - end - div do - link_to delivery_shop_orders_path(delivery_gid: delivery.gid, format: :pdf), title: "PDF", target: "_blank" do - inline_svg_tag "admin/pdf_file.svg", class: "h-5 w-5" - end - end + icon_file_link(:xlsx, shop_special_delivery_path(delivery, format: :xlsx), size: 5) + + icon_file_link(:pdf, delivery_shop_orders_path(delivery_gid: delivery.gid, format: :pdf), target: "_blank", size: 5) end end @@ -83,7 +75,7 @@ end else all.each do |producer, items| - panel producer.name, action: icon_link(:xlsx_file, "XLSX", shop_special_delivery_path(delivery, format: :xlsx, producer_id: producer.id)) do + panel producer.name, action: icon_file_link(:xlsx, shop_special_delivery_path(delivery, format: :xlsx, producer_id: producer.id)) do table_for items, i18n: Shop::OrderItem, class: "table-auto data-table-total" do column(:product) { |i| auto_link i.product } column(:product_variant) { |i| i.product_variant } diff --git a/app/assets/images/admin/clipboard-check.svg b/app/assets/images/admin/clipboard-check.svg deleted file mode 100644 index 16c165c84..000000000 --- a/app/assets/images/admin/clipboard-check.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/admin/clipboard.svg b/app/assets/images/admin/clipboard.svg deleted file mode 100644 index 39d5f4642..000000000 --- a/app/assets/images/admin/clipboard.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/admin/external-link.svg b/app/assets/images/admin/external-link.svg deleted file mode 100644 index a74e4ad64..000000000 --- a/app/assets/images/admin/external-link.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/logo.svg b/app/assets/images/logo.svg deleted file mode 100644 index 512f9c0da..000000000 --- a/app/assets/images/logo.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/basket.svg b/app/assets/images/members/basket.svg deleted file mode 100644 index 039b91b58..000000000 --- a/app/assets/images/members/basket.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/calendar.svg b/app/assets/images/members/calendar.svg deleted file mode 100644 index 4d75058b8..000000000 --- a/app/assets/images/members/calendar.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/cash.svg b/app/assets/images/members/cash.svg deleted file mode 100644 index 5387c6b6c..000000000 --- a/app/assets/images/members/cash.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/chevron_right.svg b/app/assets/images/members/chevron_right.svg deleted file mode 100644 index 31c379d36..000000000 --- a/app/assets/images/members/chevron_right.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/close.svg b/app/assets/images/members/close.svg deleted file mode 100644 index cffcca364..000000000 --- a/app/assets/images/members/close.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/app/assets/images/members/document_download.svg b/app/assets/images/members/document_download.svg deleted file mode 100644 index 7c3b84bd4..000000000 --- a/app/assets/images/members/document_download.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/globe.svg b/app/assets/images/members/globe.svg deleted file mode 100644 index 92a261ebe..000000000 --- a/app/assets/images/members/globe.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/hand.svg b/app/assets/images/members/hand.svg deleted file mode 100644 index f9ef0146a..000000000 --- a/app/assets/images/members/hand.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/identification.svg b/app/assets/images/members/identification.svg deleted file mode 100644 index 9d6cb78e2..000000000 --- a/app/assets/images/members/identification.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/information.svg b/app/assets/images/members/information.svg deleted file mode 100644 index 644a82770..000000000 --- a/app/assets/images/members/information.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/members/link.svg b/app/assets/images/members/link.svg deleted file mode 100644 index 09bdebe84..000000000 --- a/app/assets/images/members/link.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/mail.svg b/app/assets/images/members/mail.svg deleted file mode 100644 index fba795cb5..000000000 --- a/app/assets/images/members/mail.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/members/map.svg b/app/assets/images/members/map.svg deleted file mode 100644 index a3bd88474..000000000 --- a/app/assets/images/members/map.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/menu.svg b/app/assets/images/members/menu.svg deleted file mode 100644 index 8cdb36c59..000000000 --- a/app/assets/images/members/menu.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/app/assets/images/members/minus.svg b/app/assets/images/members/minus.svg deleted file mode 100644 index b795fa484..000000000 --- a/app/assets/images/members/minus.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/notice.svg b/app/assets/images/members/notice.svg deleted file mode 100644 index b1110815e..000000000 --- a/app/assets/images/members/notice.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/participant.svg b/app/assets/images/members/participant.svg deleted file mode 100644 index 5ead4f4c3..000000000 --- a/app/assets/images/members/participant.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/pencil_square.svg b/app/assets/images/members/pencil_square.svg deleted file mode 100644 index dc4d35608..000000000 --- a/app/assets/images/members/pencil_square.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/assets/images/members/phone.svg b/app/assets/images/members/phone.svg deleted file mode 100644 index 5b6fa6f8a..000000000 --- a/app/assets/images/members/phone.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/plus.svg b/app/assets/images/members/plus.svg deleted file mode 100644 index 38db7984b..000000000 --- a/app/assets/images/members/plus.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/scale.svg b/app/assets/images/members/scale.svg deleted file mode 100644 index 6fa85a98d..000000000 --- a/app/assets/images/members/scale.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/shopping_cart.svg b/app/assets/images/members/shopping_cart.svg deleted file mode 100644 index 3aca823e1..000000000 --- a/app/assets/images/members/shopping_cart.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/sign_out.svg b/app/assets/images/members/sign_out.svg deleted file mode 100644 index 0ce938562..000000000 --- a/app/assets/images/members/sign_out.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/trash.svg b/app/assets/images/members/trash.svg deleted file mode 100644 index 9e3bcba59..000000000 --- a/app/assets/images/members/trash.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/truck.svg b/app/assets/images/members/truck.svg deleted file mode 100644 index aef56c984..000000000 --- a/app/assets/images/members/truck.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/user_circle.svg b/app/assets/images/members/user_circle.svg deleted file mode 100644 index 935830ea2..000000000 --- a/app/assets/images/members/user_circle.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/members/warning.svg b/app/assets/images/members/warning.svg deleted file mode 100644 index 199099db9..000000000 --- a/app/assets/images/members/warning.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/images/admin/csv_file.svg b/app/assets/svg/icons/own/file-csv.svg similarity index 100% rename from app/assets/images/admin/csv_file.svg rename to app/assets/svg/icons/own/file-csv.svg diff --git a/app/assets/images/admin/pdf_file.svg b/app/assets/svg/icons/own/file-pdf.svg similarity index 100% rename from app/assets/images/admin/pdf_file.svg rename to app/assets/svg/icons/own/file-pdf.svg diff --git a/app/assets/images/admin/xlsx_file.svg b/app/assets/svg/icons/own/file-xlsx.svg similarity index 100% rename from app/assets/images/admin/xlsx_file.svg rename to app/assets/svg/icons/own/file-xlsx.svg diff --git a/app/assets/images/admin/logo.svg b/app/assets/svg/icons/own/logo.svg similarity index 100% rename from app/assets/images/admin/logo.svg rename to app/assets/svg/icons/own/logo.svg diff --git a/app/helpers/activities_helper.rb b/app/helpers/activities_helper.rb index e23a13388..7401d58ae 100644 --- a/app/helpers/activities_helper.rb +++ b/app/helpers/activities_helper.rb @@ -32,7 +32,7 @@ def activities_collection(activities, data: {}) content_tag(:span, class: "mr-1") { "#{activity.participants_count}/#{activity.participants_limit || '∞'}" }.concat( - icon("users", class: "ms-1 h-5 w-5 text-gray-500", library: "lucide")) + icon("users", class: "ms-1 h-5 w-5", library: "lucide", stroke_width: 2)) }) [ text, diff --git a/app/helpers/dashboard_helper.rb b/app/helpers/dashboard_helper.rb index 32d63961b..ca5fe7bde 100644 --- a/app/helpers/dashboard_helper.rb +++ b/app/helpers/dashboard_helper.rb @@ -9,9 +9,9 @@ def onboarding? end def next_delivery_panel_action(delivery) - icon_link(:csv_file, Delivery.human_attribute_name(:summary), baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv)) + - icon_link(:xlsx_file, Delivery.human_attribute_name(:summary), delivery_path(delivery, format: :xlsx)) + - icon_link(:pdf_file, Delivery.human_attribute_name(:sheets), delivery_path(delivery, format: :pdf), target: "_blank") + icon_file_link(:csv, baskets_path(q: { delivery_id_eq: delivery.id }, format: :csv), title: Delivery.human_attribute_name(:summary)) + + icon_file_link(:xlsx, delivery_path(delivery, format: :xlsx), title: Delivery.human_attribute_name(:summary)) + + icon_file_link(:pdf, delivery_path(delivery, format: :pdf), target: "_blank", title: Delivery.human_attribute_name(:sheets)) end def billing_panel_action @@ -35,7 +35,7 @@ def billing_panel_action end end end || "".html_safe - ) + icon_link(:xlsx_file, Invoice.human_attribute_name(:summary), billing_path(Current.fy_year, format: :xlsx)) + ) + icon_file_link(:xlsx, billing_path(Current.fy_year, format: :xlsx), title: Invoice.human_attribute_name(:summary)) end end end diff --git a/app/helpers/invoices_helper.rb b/app/helpers/invoices_helper.rb index 91d197b1b..257188b39 100644 --- a/app/helpers/invoices_helper.rb +++ b/app/helpers/invoices_helper.rb @@ -34,7 +34,7 @@ def link_to_invoice_pdf(invoice, title: "PDF", **options, &block) if block block.call else - inline_svg_tag "admin/pdf_file.svg", class: "w-5 h-5" + icon "file-pdf", class: "h-5 w-5", library: "own" end end end diff --git a/app/helpers/links_helper.rb b/app/helpers/links_helper.rb index 3b565eda0..dcb5fb1da 100644 --- a/app/helpers/links_helper.rb +++ b/app/helpers/links_helper.rb @@ -1,10 +1,11 @@ # frozen_string_literal: true module LinksHelper - def icon_link(icon, title, url, size: 22, **options) + def icon_file_link(type, url, size: 6, title: nil, **options) + title ||= type.upcase content_tag :span do link_to(url, title: title, **options) do - inline_svg_tag("admin/#{icon}.svg", size: size.to_s) + icon "file-#{type}", class: "h-#{size} w-#{size}", library: "own" end end end diff --git a/app/helpers/members_helper.rb b/app/helpers/members_helper.rb index 1b21bbcd2..0d90f0354 100644 --- a/app/helpers/members_helper.rb +++ b/app/helpers/members_helper.rb @@ -426,7 +426,7 @@ def collection_text(text, details: nil, icon: nil) def map_icon(location) link_to "https://www.google.com/maps?q=#{location}", title: location, target: :blank do - inline_svg_tag "members/map.svg", class: "inline-block text-gray-300 dark:text-gray-700 hover:text-green-500" + icon "map", class: "inline-block text-gray-300 dark:text-gray-700 hover:text-green-500" end end diff --git a/app/views/active_admin/_site_footer.html.slim b/app/views/active_admin/_site_footer.html.slim index c1ec9a331..3a1d1990f 100644 --- a/app/views/active_admin/_site_footer.html.slim +++ b/app/views/active_admin/_site_footer.html.slim @@ -11,5 +11,5 @@ footer class="pt-40" div class="flex justify-center py-8 mt-4" = link_to csa_admin_website_url, class: "inline-flex items-center text-sm py-1 px-2 text-gray-300 dark:text-gray-700 hover:text-green-600 hover:text-green-600 dark:hover:text-green-500 hover:bg-gray-100 dark:hover:bg-gray-700 font-medium focus:outline-none rounded-md no-underline" do - = inline_svg_tag('admin/logo.svg', size: '16', class: 'me-2 fill-current') + = icon "logo", class: "w-4 h-4 me-2 fill-current", library: "own" = 'CSA Admin' diff --git a/app/views/active_admin/_site_header.html.erb b/app/views/active_admin/_site_header.html.erb index 490ba63ab..e0d469946 100644 --- a/app/views/active_admin/_site_header.html.erb +++ b/app/views/active_admin/_site_header.html.erb @@ -48,7 +48,7 @@