Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create space error message #2452

Merged
merged 1 commit into from
Jan 18, 2022
Merged

fix create space error message #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-create-space-error-msg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: fix create space error message

Create space no longer errors with list spaces error messages.

https://github.com/cs3org/reva/pull/2452
4 changes: 2 additions & 2 deletions internal/grpc/services/storageprovider/storageprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
var st *rpc.Status
switch err.(type) {
case errtypes.IsNotFound:
st = status.NewNotFound(ctx, "not found when listing spaces")
st = status.NewNotFound(ctx, "not found when creating space")
case errtypes.PermissionDenied:
st = status.NewPermissionDenied(ctx, err, "permission denied")
case errtypes.NotSupported:
Expand All @@ -506,7 +506,7 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
case errtypes.AlreadyExists:
st = status.NewAlreadyExists(ctx, err, "already exists")
default:
st = status.NewInternal(ctx, "error listing spaces")
st = status.NewInternal(ctx, "error creating space")
appctx.GetLogger(ctx).
Error().
Err(err).
Expand Down