Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge: WOPI server may encounter two different fileids for same resource #2635

Closed
butonic opened this issue Mar 14, 2022 · 1 comment
Closed
Labels
bug Something isn't working p1-urgent

Comments

@butonic
Copy link
Contributor

butonic commented Mar 14, 2022

When a publicly shared file is edited by a logged in user and a guest user the fileid is different for a resoucre is different when accessing it via a public link. This causes problems with the WOPI extension where users may enter and leave an edit session. If the fileid changes writes may fail when the original editor leaves the session.

In any case the public storage provider MUST NOT replace the storage space id in the reference with a public storage space id.

The current approach of returning a type:public storage space when listing spaces is wrong.

The correct approach is to only return a space for a resource when dealing with public link requests. That would also eliminate the public storage space in the listing of spaces a user has access to.

This will change the implementation significantly, basically it is a rewrite.

@butonic butonic added the bug Something isn't working label Mar 14, 2022
@wkloucek
Copy link
Contributor

wkloucek commented May 3, 2022

already fixed in #2646 👍

@wkloucek wkloucek closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1-urgent
Projects
None yet
Development

No branches or pull requests

3 participants