Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcloud: make InsecureSkipVerify configurable #1411

Closed
labkode opened this issue Jan 19, 2021 · 2 comments · Fixed by #1589
Closed

xcloud: make InsecureSkipVerify configurable #1411

labkode opened this issue Jan 19, 2021 · 2 comments · Fixed by #1589
Assignees
@sudo-sturbia
Labels
junior-job Easy issues

Comments

@labkode
Copy link
Member

labkode commented Jan 19, 2021

No description provided.

@ishank011 ishank011 added the junior-job Easy issues label Mar 11, 2021
@sudo-sturbia
Copy link
Contributor

Hi, I'd like to do this if it's possible. I plan to add InsecureSkipVerify field to metrics.Config struct, and update the examples to include it. Please let me know if you have another opinion.

@ishank011
Copy link
Contributor

Hi @sudo-sturbia. Yep, that's it. Please go ahead!

@sudo-sturbia sudo-sturbia mentioned this issue Mar 26, 2021
Merged
@fschade fschade mentioned this issue Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudo-sturbia sudo-sturbia

Labels
junior-job Easy issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xcloud: make InsecureSkipVerify configurable sudo-sturbia/reva
3 participants
@labkode @ishank011 @sudo-sturbia