diff --git a/changelog/unreleased/delete-all-spaces-perm.md b/changelog/unreleased/delete-all-spaces-perm.md index c0cef149c6..21c76c6911 100644 --- a/changelog/unreleased/delete-all-spaces-perm.md +++ b/changelog/unreleased/delete-all-spaces-perm.md @@ -1,6 +1,6 @@ Enhancement: Added "delete-all-spaces" permission -We introduced a new permission "delete-all-spaces", user holding this permission are allowed +We introduced a new permission "delete-all-spaces", users holding this permission are allowed to delete any space of any type. https://github.com/cs3org/reva/pull/3203 diff --git a/pkg/storage/utils/decomposedfs/spaces.go b/pkg/storage/utils/decomposedfs/spaces.go index 3a9457dcd2..bbd8a9d8c6 100644 --- a/pkg/storage/utils/decomposedfs/spaces.go +++ b/pkg/storage/utils/decomposedfs/spaces.go @@ -644,8 +644,8 @@ func (fs *Decomposedfs) DeleteStorageSpace(ctx context.Context, req *provider.De } // - a User with the "delete-all-spaces" permission can delete any space - // - spaces of type personal can also be delete by user with the "delete-all-home-spaces" permission - // - otherwise a space can be deleted by it's manager (i.e. users have the "remove" grant) + // - spaces of type personal can also be deleted by users with the "delete-all-home-spaces" permission + // - otherwise a space can be deleted by its manager (i.e. users have the "remove" grant) switch { case fs.canDeleteAllSpaces(ctx): // We are allowed to delete any space, no further permission checks needed