Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscore in variable naming convention #1034

Closed
0xalpharush opened this issue Feb 4, 2022 · 4 comments
Closed

Allow underscore in variable naming convention #1034

0xalpharush opened this issue Feb 4, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@0xalpharush
Copy link
Contributor

It's pretty common to include underscores to prefix internal variables or to distinguish between arguments and state variables. We should not include these in the camel case naming convention detector

@stephenctw
Copy link

They claim to support the underscore rule but I also hit this issue.

@smallbatch-apps
Copy link

This is affecting us, too. The use of _name or name_ to prevent collision is very common, and necessary. Using _name should not trigger an error, as it is a standard convention.

@0xalpharush
Copy link
Contributor Author

This lines need to be update to include internal state variables:

@0xalpharush 0xalpharush added the good first issue Good for newcomers label Mar 25, 2023
@devtooligan
Copy link
Contributor

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants