Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make deployment order optional #245

Closed
0xPhaze opened this issue Oct 19, 2023 · 2 comments
Closed

feat: make deployment order optional #245

0xPhaze opened this issue Oct 19, 2023 · 2 comments

Comments

@0xPhaze
Copy link

0xPhaze commented Oct 19, 2023

For improved user experience, we could simply deploy contracts in an arbitrary (alphabetical) order. I think in most cases it might not matter what the order is. This should be an optional feature.

error Failed to initialize the test chain
‣ you must specify a contract deployment order within your project configuration
Copy link
Collaborator

anishnaik commented Oct 19, 2023

So deploymentOrder unfortunately cannot be optional. It is equivalent to --target in echidna. You have to tell medusa what to actually fuzz test. This is a mistake we made when naming the configuration options in medusa. Think of deploymentOrder as a list of targets. While Echidna allows you to fuzz only 1 target at a time, medusa allows you to target more than one. At the end of the day you only want to deploy things to the blockchain that you actually want to fuzz test. Alphabetically deploying everything would not tell you what to actually fuzz test at the end of the day.

This is in contrast to the compilation target. This, unfortunately, in medusa is called --target src/Counter.sol whereas in echidna it would be echidna src/Counter.sol.

We have a PR that will change the config options as follows:

  • deploymentOrder -> targetContracts
  • target -> compilationTarget

Lmk if you have any further questions, otherwise will close this issue.

@0xPhaze
Copy link
Author

0xPhaze commented Oct 19, 2023

Ah I see, that makes sense. Closing then.

@0xPhaze 0xPhaze closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants