Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medusa needs a command line/config option to better define which contracts are targeted #145

Closed
ggrieco-tob opened this issue May 8, 2023 · 4 comments · Fixed by #216
Closed

Comments

@ggrieco-tob
Copy link
Member

This issue is related to #132. The use deploymentOrder is useful to simplify deployments, but it doesn't allow to specify which contract contains the tests or which contract actually should be called during the campaign. In echidna, we have the ``--contract` command line to specify the contract name (if there are more than one contract) and by default this will be the contract that will have tests and functions to call. I think the same should be implemented in medusa.

@Xenomega
Copy link
Member

Xenomega commented May 8, 2023

TestAllContracts set to false should only test deploymentOrder contracts (similar to echidna's --contract). With #132, the idea would be to filter the called contracts to only deploymentOrder contracts too. Which would match echidna's behavior (I believe). Would this then be adequate? Or were you thinking of something more customizable, like allowing you to specify a different list to target for calls/tests?

@ggrieco-tob
Copy link
Member Author

We need to be able to specify a single contract name, from deploymentOrder to match echidna behavior.

@Xenomega
Copy link
Member

Xenomega commented May 8, 2023

Ah I see. We should add more granular filters to called/tested contracts then, rather than having it as a bool, presumably.

@anishnaik
Copy link
Collaborator

While #51 is tackled, testAllContracts should be false by default and only stuff in the deploymentOrder should be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants