Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crystal: previous option #52

Open
Sija opened this issue Jan 15, 2025 · 6 comments
Open

Add crystal: previous option #52

Sija opened this issue Jan 15, 2025 · 6 comments

Comments

@Sija
Copy link

Sija commented Jan 15, 2025

I'd like to suggest adding previous (or previous-minor) as the version option (following latest), allowing automatically selecting previous MINOR version for testing. That would help to catch any new additions in terms of BC.

@oprypin
Copy link
Member

oprypin commented Jan 15, 2025

What's "BC"?

@Sija
Copy link
Author

Sija commented Jan 15, 2025

Backward Compatibility

@straight-shoota
Copy link
Member

For backwards compatibility, wouldn't it be better to specify explicit versions that you want to ensure compatibility with? previous would just be a moving target, so it's not exactly clear which versions are considered to be backward compatible.

@Sija
Copy link
Author

Sija commented Jan 15, 2025

@straight-shoota That's exactly my point, the case at-hand is testing features that are working with Crystal latest onwards and checking whether the build still succeeds with the previous one, like in this PR: crystal-ameba/ameba#536

@straight-shoota
Copy link
Member

But how is a floating target latest better than pinning a specific version?

@Sija
Copy link
Author

Sija commented Jan 15, 2025

It's not about better, but a specific use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants