Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OptionParser.parse! #7846

Closed
didactic-drunk opened this issue Jun 2, 2019 · 0 comments
Closed

Remove OptionParser.parse! #7846

didactic-drunk opened this issue Jun 2, 2019 · 0 comments
Labels
breaking-change kind:refactor topic:stdlib

Comments

@didactic-drunk
Copy link
Contributor

didactic-drunk commented Jun 2, 2019 •
edited
Loading

OptionParser.parse! is redundant and could be handled by OptionParser.parse using a default variable.

New way:

def parse(args = ARGV)

Old way:

def self.parse(args)

# uses argv
def self.parse!
  ...
  parse ARGV
  ...
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change kind:refactor topic:stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhass @didactic-drunk