Sementic: prevent infinity recursion by alias and generics combination #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
reviewed
Nov 28, 2017
| @@ -667,7 +667,10 @@ module Crystal | |||
| elsif context.strict? | |||
| type_var == other_type_var | |||
| else | |||
| type_var.restrict(other_type_var, context) == type_var | |||
| # To prevent infinity recursion, it checks equality between | |||
There was a problem hiding this comment.
Something that reaches "infinity" is "infinite", it has no "finite" amount ;)
jhass
approved these changes
Nov 28, 2017
lachlan
reviewed
Nov 28, 2017
spec/compiler/semantic/alias_spec.cr
Outdated
| @@ -297,4 +297,17 @@ describe "Semantic: alias" do | |||
| ), | |||
| "undefined constant T" | |||
| end | |||
|
|
|||
| it "doesn't crash by infinity recustion against type alias and generics (#5329)" do | |||
There was a problem hiding this comment.
Typo: recustion should be recursion.
ysbaddaden
approved these changes
Nov 28, 2017
RX14
approved these changes
Nov 28, 2017
RX14
added
kind:bug
makenowjust
deleted the
fix/crystal/5329-prevent-alias-and-generics-infinity-recursion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5329
See comments in source code. Thank you.