Doc: use string array delimiter as-is input on highlight #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current highlighter implementation losts string array delimiter information, and replaces it with `%w(` or `%i(`. Highlighter should respect user input, and it can produce invalid Crystal code if string array item has `)`.
RX14
approved these changes
Nov 17, 2017
RX14
added
kind:bug
bcardiff
approved these changes
Nov 18, 2017
|
Thanks @makenowjust |
makenowjust
deleted the
fix/crystal-doc/show-string-array-as-is-input-on-highlight
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current highlighter implementation loses string array delimiter information, and replaces it with
%w(or%i(. Highlighter should respect user input and it can produce invalid Crystal code if string array item has).For example,
src/string_array.cr:and generated is:
Thank you.