Give error if using instance_sizeof on a generic type without type vars #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Oct 29, 2017
|
LGTM 👍 ? |
|
@sdogruyol in the interests of keeping noise down, can you not "LGTM" random prs, unless they need bumping (this PR isn't even a day old). |
|
@RX14 they're mostly approved PRs not random.. |
|
Ok but its still not helpful |
|
I agree, the LGTM end up in my mail box and when I think there's some new interesting reply or something relevant to the issue, it's just a 👍 . Let's avoid that. |
asterite
requested changes
Oct 30, 2017
| raise "BUG: #{node} at #{node.location} should receive a type" | ||
| end | ||
|
|
||
| if type.is_a? GenericClassType |
There was a problem hiding this comment.
This should be GenericType. That's the base module for both generic classes and modules.
lbguilherme
force-pushed
the
instance_sizeof
branch
from
ec94145 to
8c2d6eb
Compare
|
@asterite Done. |
lbguilherme
force-pushed
the
instance_sizeof
branch
from
8c2d6eb to
07ca484
Compare
asterite
approved these changes
Nov 2, 2017
RX14
approved these changes
Nov 3, 2017
RX14
added
kind:bug
ddrscott
added a commit
to ddrscott/crystal
that referenced
this pull request
Apr 6, 2018
After some `git bisect` work, it was discovered that the following bug fix causes a regression on a patch which should be detectable. > 074d61c is the first bad commit > commit 074d61c > Author: Guilherme Bernal <[email protected]> > Date: Fri Nov 3 11:44:21 2017 -0300 > > give error if using instance_sizeof on a generic type without type vars (crystal-lang#5209) > > :040000 040000 2fa5bdc54dead5c6c70f011e4e131f74bc170156 546f4b9d362c210b3b26f688e9314fb31ea64acb M spec > :040000 040000 a3694241ab2bdfc038018e3280758fa3937b29de 80ec4ae5f0c337447208280893acb2fca45dbf5b M src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5207