Extend known HTTP default status messages by RFC's #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
May 16, 2017
src/http/common.cr
Outdated
| when 428 then "Precondition Required" | ||
| when 429 then "Too Many Requests" | ||
| when 431 then "Request Header Fields Too Large" | ||
| when 449 then "Retry with" # unofficial Microsoft |
There was a problem hiding this comment.
Yes, it looks more consistently. Force updated.
…2324 etc. Heavily inpsired by CPAN HTTP::Status module.
akzhan
force-pushed
the
extend-http-status-codes
branch
from
bff5a2c to
6a7f90b
Compare
|
Looks good to me. |
|
Thanks @akzhan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2518, RFC 5842, RFC 2324 etc.
Heavily inspired by CPAN HTTP::Status module.