Allow passing non heap objects to WeakRef #4293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow at least pointers to the data section to work seamlessly with WeakRef and in some cases even allow stack pointers to be passed, for the crazy. This should increase the usability of WeakRef since it allows passing static data for testing or other purposes.
This also renames WeakRef#target to
WeakRef#getWeakRef#value.get seems to be the more general, more widely used and shorter name.value is consistent with Pointer. Additionally target feels like it's leaking implementation details asthat's the name of the internal instance variable too.
As expected this is slightly slower for the heap case, given the additional check, and slightly faster for the non-heap case, given the check is less expensive than registering a pointer with GC. A quick benchmark with collection disabled so the second testcase wouldn't crash: